Gilad Chaplik has posted comments on this change. Change subject: core, db: disk profile: handle attach/detach ......................................................................
Patch Set 11: (3 comments) http://gerrit.ovirt.org/#/c/29037/11/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/DiskProfileDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/profiles/DiskProfileDao.java: Line 18: List<DiskProfile> getAllForStorageDomain(Guid storageDomainId); Line 19: Line 20: /** Line 21: * when detaching SD for data center, we should remove any attachement to qos, which is part of the Line 22: * old data center > yes, it's relevant to there...not to the dao Done Line 23: * Line 24: * @param storageDomainId Line 25: * Detached storage domain id Line 26: */ Line 23: * Line 24: * @param storageDomainId Line 25: * Detached storage domain id Line 26: */ Line 27: void nullifyQosForStorageDomain(Guid storageDomainId); > I think that the name is okay (anyway it's not significantly different from prefer to do what's needed, and not generalize for now. Line 28: http://gerrit.ovirt.org/#/c/29037/11/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoTest.java: Line 128: } Line 129: Line 130: public void nullifyQosForStorageDomain() { Line 131: dao.nullifyQosForStorageDomain(FixturesTool.STORAGE_DOAMIN_SCALE_SD5); Line 132: List<DiskProfile> allForStorageDomain = dao.getAllForStorageDomain(FixturesTool.STORAGE_DOAMIN_SCALE_SD5); > line 136 checks that it's null after the update, not the value before. Done Line 133: assertNotNull(allForStorageDomain); Line 134: assertFalse(allForStorageDomain.isEmpty()); Line 135: for (DiskProfile diskProfile : allForStorageDomain) { Line 136: assertNull(diskProfile.getQosId()); -- To view, visit http://gerrit.ovirt.org/29037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29aaf7b0b537f0b80b91b09e025e9487bbb69c2d Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
