Daniel Erez has uploaded a new change for review. Change subject: webadmin: attach disk - allow read-only for DirectLUN ......................................................................
webadmin: attach disk - allow read-only for DirectLUN Attach disk dialog: allow read-only selection for DirecLUN disks not using SCSI pass-through. Change-Id: Id2ff8730b7da1d20e71339871ee462c23d263c5b Bug-Url: https://bugzilla.redhat.com/1118847 Signed-off-by: Daniel Erez <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/31343/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java index 52645a2..248fbb9 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java @@ -267,10 +267,9 @@ protected boolean canEdit(EntityModel object) { DiskModel diskModel = (DiskModel) object.getEntity(); Disk disk = diskModel.getDisk(); - boolean lunIscsiLimitation = - (disk.getDiskInterface() == DiskInterface.VirtIO_SCSI && disk.getDiskStorageType() == DiskStorageType.LUN); + boolean isScsiPassthrough = disk.isScsiPassthrough(); boolean ideLimitation = (disk.getDiskInterface() == DiskInterface.IDE); - return !lunIscsiLimitation && !ideLimitation; + return !isScsiPassthrough && !ideLimitation; } @Override -- To view, visit http://gerrit.ovirt.org/31343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id2ff8730b7da1d20e71339871ee462c23d263c5b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
