Gilad Chaplik has posted comments on this change. Change subject: core: Collect vm numa node runtime information ......................................................................
Patch Set 11: Code-Review-1 (2 comments) setting -1 for visibility. http://gerrit.ovirt.org/#/c/28096/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java: Line 15: private List<VmJob> vmJobs; Line 16: // NOT PERSISTED Line 17: private VmBalloonInfo vmBalloonInfo; Line 18: // NOT PERSISTED Line 19: private List<VmNumaNode> vNumaNodeStatisticsList; why you're not using existing VmNumaNode? Line 20: Line 21: public VmStatistics() { Line 22: cpu_sysField = 0.0; Line 23: cpu_userField = 0.0; http://gerrit.ovirt.org/#/c/28096/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 2074: } Line 2075: } Line 2076: Line 2077: private void updateVmNumaNodeRuntimeInfo(VmStatistics statistics, VM vm) { Line 2078: if (vm.getRunOnVds() == null) { question: incase VM is going down, what will clean the stats? Line 2079: return; Line 2080: } Line 2081: Line 2082: //Build numa nodes map of the host which the vm is running on with node index as the key -- To view, visit http://gerrit.ovirt.org/28096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
