Oved Ourfali has posted comments on this change. Change subject: core: Skip fencing if network unstable ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/31303/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java: Line 293: entity.setSerialNumberPolicy(SerialNumberPolicy.forValue((Integer) rs.getObject("serial_number_policy"))); Line 294: entity.setCustomSerialNumber(rs.getString("custom_serial_number")); Line 295: entity.getFencingPolicy().setSkipFencingIfSDActive(rs.getBoolean("skip_fencing_if_sd_active")); Line 296: entity.getFencingPolicy().setSkipFencingIfNetworkUnstable(rs.getBoolean("skip_fencing_if_network_unstable")); Line 297: entity.getFencingPolicy().setHostsWithUnstableNetworkThreshold(rs.getInt("hosts_with_unstable_network_threshold")); why are we persisting it? Line 298: Line 299: return entity; Line 300: } Line 301: } http://gerrit.ovirt.org/#/c/31303/2/packaging/dbscripts/upgrade/03_06_0130_skip_fencing_when_sd_is_alive.sql File packaging/dbscripts/upgrade/03_06_0130_skip_fencing_when_sd_is_alive.sql: Line 1: -- By default set to false not to break upgrade Line 2: SELECT fn_db_add_column('vds_groups', 'skip_fencing_if_sd_active', 'boolean DEFAULT false'); why is this one here? just make sure to remove it -- To view, visit http://gerrit.ovirt.org/31303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a9c7db43b50421414ce9596137767b00cbfc2ae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
