Oved Ourfali has posted comments on this change. Change subject: UI: Adding support for setting skip if network... ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/31305/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 1589: } Line 1590: Line 1591: private void initHostsWithUnstableNetworkThreshold() { Line 1592: // populating threshold values with {0, 25, 50, 75, 100} Line 1593: for (int i=0; i<=100; i+=25) { add some spacing. Line 1594: privateHostsWithUnstableNetworkThreshold.getItems().add(i); Line 1595: } Line 1596: } Line 1597: http://gerrit.ovirt.org/#/c/31305/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 805: Line 806: @DefaultStringValue("Skip fencing if host has live lease on storage") Line 807: String skipFencingIfSDActive(); Line 808: Line 809: @DefaultStringValue("Disrupt fence request if more than X% Hosts have networking problems") Disrupt fence request if the percentage of Cluster Hosts with connectivity issues exceeds defined threshold. Line 810: String skipFencingWhenNetworkUnstable(); Line 811: Line 812: @DefaultStringValue("Threshold of Hosts having network problems") Line 813: String hostsWithUnstableNetworkThresholdLabel(); Line 808: Line 809: @DefaultStringValue("Disrupt fence request if more than X% Hosts have networking problems") Line 810: String skipFencingWhenNetworkUnstable(); Line 811: Line 812: @DefaultStringValue("Threshold of Hosts having network problems") Threshold of Cluster Hosts with connectivity issues Line 813: String hostsWithUnstableNetworkThresholdLabel(); Line 814: Line 815: @DefaultStringValue("Name") Line 816: String bookmarkPopupNameLabel(); Line 3804: Line 3805: @DefaultStringValue("This will skip fencing for a Host that has live lease on Storage Domains") Line 3806: String skipFencingIfSDActiveInfo(); Line 3807: Line 3808: @DefaultStringValue("This will disrupt fence request on a Hots if its Cluster has more than X% Hosts with networking problems") Change to something similar to above. Line 3809: String skipFencingWhenNetworkUnstableInfo(); -- To view, visit http://gerrit.ovirt.org/31305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d300b37a49261744d81fd397772f70e56e7a688 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
