Liran Zelkha has uploaded a new change for review. Change subject: core: Fix QuartzException when Ctrl+C engine ......................................................................
core: Fix QuartzException when Ctrl+C engine When shuting down engine in dev environment using Ctrl+C exceptions are printed to the screen because of Quartz shutdown. This patch validates that the scheduler can indeed reschedule a job before rescheduling it. Exception Dump is: failed to reschedule the job: org.quartz.SchedulerException: The Scheduler has been shutdown. at org.quartz.core.QuartzScheduler.validateState(QuartzScheduler.java:749) [quartz.jar:] at org.quartz.core.QuartzScheduler.rescheduleJob(QuartzScheduler.java:1060) [quartz.jar:] at org.quartz.impl.StdScheduler.rescheduleJob(StdScheduler.java:312) [quartz.jar:] at org.ovirt.engine.core.utils.timer.SchedulerUtilQuartzImpl.rescheduleAJob(SchedulerUtilQuartzImpl.java:331) [scheduler.jar:] at org.ovirt.engine.core.utils.timer.FixedDelayJobListener.jobWasExecuted(FixedDelayJobListener.java:91) [scheduler.jar:] Change-Id: I3fcdc3aa51bbcdf817363af6431db488501aa401 Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: lzel...@redhat.com <lzel...@redhat.com> --- M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/10/31310/1 diff --git a/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java b/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java index c77bae8..74382aa 100644 --- a/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java +++ b/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java @@ -328,7 +328,9 @@ */ public void rescheduleAJob(String oldTriggerName, String oldTriggerGroup, Trigger newTrigger) { try { - sched.rescheduleJob(triggerKey(oldTriggerName, oldTriggerGroup), newTrigger); + if (!sched.isShutdown()) { + sched.rescheduleJob(triggerKey(oldTriggerName, oldTriggerGroup), newTrigger); + } } catch (SchedulerException se) { log.error("failed to reschedule the job", se); } -- To view, visit http://gerrit.ovirt.org/31310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3fcdc3aa51bbcdf817363af6431db488501aa401 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
