Liron Aravot has posted comments on this change. Change subject: core: attach device ioTune map ......................................................................
Patch Set 6: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/29816/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 376: if (storageQosId == null) { Line 377: StorageQos storageQos = DbFacade.getInstance().getStorageQosDao().getQosByDiskProfileId(diskProfileId); Line 378: if (storageQos == null) { Line 379: return null; Line 380: } else { no need for the else word Line 381: storageQosId = storageQos.getId(); Line 382: diskProfileStorageQosMap.put(diskProfileId, storageQosId); Line 383: storageQosIoTuneMap.put(storageQosId, buildIoTuneMap(storageQos)); Line 384: } Line 385: } Line 386: Line 387: Map<String, Integer> ioTuneMap = storageQosIoTuneMap.get(storageQosId); Line 388: // return map with values Line 389: if (ioTuneMap.size() > 0) { isEmpty Line 390: return ioTuneMap; Line 391: } Line 392: return null; Line 393: } -- To view, visit http://gerrit.ovirt.org/29816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I515caa7ff8996711610a77a57d6683d2655545de Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
