Liron Aravot has posted comments on this change. Change subject: core, db: Introduce BaseProfile and DiskProfile ......................................................................
Patch Set 22: Code-Review+2 (2 comments) http://gerrit.ovirt.org/#/c/27099/22/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoTest.java: Line 119: * Ensures that the remove is working correctly Line 120: */ Line 121: @Test Line 122: public void testRemove() { Line 123: dao.save(diskProfile); please remove an existing one instead of saving and removing Line 124: DiskProfile result = dao.get(diskProfile.getId()); Line 125: assertNotNull(result); Line 126: dao.remove(diskProfile.getId()); Line 127: assertNull(dao.get(diskProfile.getId())); http://gerrit.ovirt.org/#/c/27099/22/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 5065: <value>77296e00-0cad-4e5a-9299-008a7b6f4354</value> Line 5066: </row> Line 5067: </table> Line 5068: Line 5069: <table name="disk_profiles"> please reduce to the used amount within the tests (2 records) Line 5070: <column>id</column> Line 5071: <column>name</column> Line 5072: <column>storage_domain_id</column> Line 5073: <column>qos_id</column> -- To view, visit http://gerrit.ovirt.org/27099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I229af59277b5055453188f002f19046cdd51d63b Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
