Ravi Nori has uploaded a new change for review.

Change subject: webadmin: 'Add Users and Groups' dialog the column size should 
be limited
......................................................................

webadmin: 'Add Users and Groups' dialog the column size should be limited

The column with the long name looks long
and we need to scroll right/left to see
the other columns

Change-Id: Ia3009bffce854cc99031ad6571affea328c437d1
Bug-Url: https://bugzilla.redhat.com/1126283
Signed-off-by: Ravi Nori <rn...@redhat.com>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
1 file changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/60/31260/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
index da34c81..0c067c3 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
@@ -107,6 +107,7 @@
         super(eventBus, resources);
         initListBoxEditors();
         searchItems = new EntityModelCellTable<ListModel>(true);
+        searchItems.enableColumnResizing();
         initWidget(ViewUiBinder.uiBinder.createAndBindUi(this));
         generateIds();
         searchStringEditor.setStyleName("");
@@ -144,27 +145,28 @@
     }
 
     private void initTable(CommonApplicationConstants constants) {
+        String width = "284px"; //$NON-NLS-1$
         // Table Entity Columns
-        searchItems.addEntityModelColumn(new EntityModelTextColumn<DbUser>() {
+        searchItems.addColumn(new EntityModelTextColumn<DbUser>() {
             @Override
             public String getText(DbUser user) {
                 return user.getFirstName();
             }
-        }, constants.firsNamePermissionsPopup());
+        }, constants.firsNamePermissionsPopup(), width);
 
-        searchItems.addEntityModelColumn(new EntityModelTextColumn<DbUser>() {
+        searchItems.addColumn(new EntityModelTextColumn<DbUser>() {
             @Override
             public String getText(DbUser user) {
                 return user.getLastName();
             }
-        }, constants.lastNamePermissionsPopup());
+        }, constants.lastNamePermissionsPopup(), width);
 
-        searchItems.addEntityModelColumn(new EntityModelTextColumn<DbUser>() {
+        searchItems.addColumn(new EntityModelTextColumn<DbUser>() {
             @Override
             public String getText(DbUser user) {
                 return user.getLoginName();
             }
-        }, constants.userNamePermissionsPopup());
+        }, constants.userNamePermissionsPopup(), width);
     }
 
     void localize(CommonApplicationConstants constants) {


-- 
To view, visit http://gerrit.ovirt.org/31260
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3009bffce854cc99031ad6571affea328c437d1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to