Martin Peřina has uploaded a new change for review. Change subject: core: Refactor FenceVdsActionParameters ......................................................................
core: Refactor FenceVdsActionParameters Refactors FenceVdsActionParameters: 1) Moves instance attributes before methods 2) Remove '_' from attribute names 3) Use constructor chaining 4) Set default values of instance variables in constructor Change-Id: I43bc8d5336633cf0f259d08803d2e902be006791 Bug-Url: https://bugzilla.redhat.com/1090799 Signed-off-by: Martin Perina <mper...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/34/31234/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java index 168962d..3b76cb5 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java @@ -13,26 +13,26 @@ * * If the user triggered this action, clear the flag. */ - private boolean keepPolicyPMEnabled = false; + private boolean keepPolicyPMEnabled; + + private FenceActionType action; + + public FenceVdsActionParameters() { + this(null, FenceActionType.Restart); + } public FenceVdsActionParameters(Guid vdsId, FenceActionType action) { - super(vdsId); - _action = action; + this(vdsId, action, false); } public FenceVdsActionParameters(Guid vdsId, FenceActionType action, boolean keepPolicyPMEnabled) { - this(vdsId, action); + super(vdsId); + this.action = action; this.keepPolicyPMEnabled = keepPolicyPMEnabled; } - private FenceActionType _action; - public FenceActionType getAction() { - return _action; - } - - public FenceVdsActionParameters() { - _action = FenceActionType.Restart; + return action; } public boolean getKeepPolicyPMEnabled() { -- To view, visit http://gerrit.ovirt.org/31234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I43bc8d5336633cf0f259d08803d2e902be006791 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Peřina <mper...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
