Karnan t c has posted comments on this change. Change subject: gluster-nagios-monitoring: Added date validation error message on trends tab ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/31004/1/gluster-nagios-monitoring/src/js/trends.js File gluster-nagios-monitoring/src/js/trends.js: Line 484: var latestGraphs = []; Line 485: var stopDate = $rootScope.stopDate; Line 486: var stopTime = $rootScope.stopTime; Line 487: var stopFullDate = graphUtils.prepareDate(stopDate , stopTime); Line 488: if (stopFullDate.getTime() < startFullDate.getTime()) { > I think we should handle '=' as well. The probability of occurrence of this As we are displaying a area chart start when date/time and end date/time are equal it gives trend at that specific point in time. '=' is not required Line 489: alert("The To date-time must be greater than the From date-time"); Line 490: } Line 491: else if ((($scope.graphs)) && ($scope.graphs.length > 0)) { Line 492: latestGraphs = dataManager.appendUrlsWithTime($scope.graphs, startFullDate, stopFullDate); Line 485: var stopDate = $rootScope.stopDate; Line 486: var stopTime = $rootScope.stopTime; Line 487: var stopFullDate = graphUtils.prepareDate(stopDate , stopTime); Line 488: if (stopFullDate.getTime() < startFullDate.getTime()) { Line 489: alert("The To date-time must be greater than the From date-time"); > Remove the tab space in previous line. Tab should be replaced with space. Done Line 490: } Line 491: else if ((($scope.graphs)) && ($scope.graphs.length > 0)) { Line 492: latestGraphs = dataManager.appendUrlsWithTime($scope.graphs, startFullDate, stopFullDate); Line 493: for(var i = 0 ; i < latestGraphs.length ; i++) { -- To view, visit http://gerrit.ovirt.org/31004 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id84d02203cd94a780303c5e802dba82e3db500ce Gerrit-PatchSet: 1 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Karnan t c <kchid...@redhat.com> Gerrit-Reviewer: Karnan t c <kchid...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
