David Caro has posted comments on this change. Change subject: jobs: preserve suffix while building in mock ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31188/2/jobs/confs/shell-scripts/build_local_srcrpm.sh File jobs/confs/shell-scripts/build_local_srcrpm.sh: Line 30: # Build the src_rpms Line 31: # Get the release suffix Line 32: pushd "$WORKSPACE/$project" Line 33: suffix=".$(date -u +%Y%m%d%H%M%S).git$(git rev-parse --short HEAD)" Line 34: echo "export suffix=${suffix}" > "${WORKSPACE}/suffix.sh" > Can we define a cleanup action to be executed in any case at the end of the The problem with the cleanup is that it's external to this scripts/scripts, so I think that the optimal should be a bit more generic, maybe creating a tmp dir inside the workspace that gets deleted always, so any temporary local file can be created and is sure it will get deleted. The timestamp thingie, I don't like it, as you don't control how much time can pass between the scripts or anything. And times are not reliable Still giving it a thought, I will decide before going away today and offer a working solution, based on this patch so tomorrow we can keep reviewing and merge the patch together. Line 35: Line 36: # make sure it's properly clean Line 37: git clean -dxf Line 38: # build tarballs -- To view, visit http://gerrit.ovirt.org/31188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5e4cd292a2c9c8b641ca57e31b80f5a05b81e68 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
