Arik Hadas has posted comments on this change. Change subject: engine: allow to fetch all QoS for REST ......................................................................
Patch Set 14: Code-Review+1 (3 comments) http://gerrit.ovirt.org/#/c/28767/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QosQueryBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QosQueryBase.java: Line 22: case STORAGE: Line 23: qosDao = getDbFacade().getStorageQosDao(); Line 24: break; Line 25: Line 26: default: how about adding a log with the given qosType? Line 27: break; Line 28: } Line 29: return qosDao; Line 30: } http://gerrit.ovirt.org/#/c/28767/14/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/AllQosBaseDaoFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/AllQosBaseDaoFacadeImpl.java: Line 18: Line 19: @Override Line 20: /** Line 21: * qosType can be null in order to fetch all entities Line 22: */ this comment is irrelevant here, right? Line 23: public List<QosBase> getAllForStoragePoolId(Guid storagePoolId) { Line 24: MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() Line 25: .addValue("storage_pool_id", storagePoolId.getUuid()); Line 26: return getCallsHandler().executeReadList("GetAllQosForStoragePool", Line 45: protected QosBase createQosEntity(ResultSet rs) throws SQLException { Line 46: switch (QosType.forValue(rs.getInt("qos_type"))) { Line 47: case STORAGE: Line 48: return StorageQosDaoDbFacadeImpl.StorageDaoDbFacadaeImplMapper.MAPPER.createQosEntity(rs); Line 49: default: log? Line 50: break; Line 51: } Line 52: Line 53: return null; -- To view, visit http://gerrit.ovirt.org/28767 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e55d3e7643c42f48c971400b15f6eb92e50ccaa Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
