[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Fix name textbox size/alignment on Clone Vm From S...

[mbetak]

Hello Greg Sheremeta,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/31159

to review the following change.

Change subject: webadmin: Fix name textbox size/alignment on Clone Vm From 
Snapshot
......................................................................

webadmin: Fix name textbox size/alignment on Clone Vm From Snapshot

Change-Id: I2f865deab00cab1e56fd39e6b2f9a00f507c4a26
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1126215
Signed-off-by: Martin Betak <mbe...@redhat.com>
Signed-off-by: Greg Sheremeta <gsher...@redhat.com>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
2 files changed, 26 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/31159/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
index 4a5f8e6..55055e3 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
@@ -212,19 +212,40 @@
             margin-bottom: 10px;
         }
 
-        .poolEditVms, .name {
+        .poolEditVms {
             line-height: 30px;
             padding: 0 5px;
             padding-bottom: 35px;
         }
 
-        .prestartedVmsEditorContent, .nameEditorContent, 
.maxAssignedVmsPerUserEditorContent {
+        .name {
+            line-height: 30px;
+        }
+
+        .nameLabel {
+            font-size: 13px;
+            padding: 0 5px;
+            font-family: Arial, sans-serif;
+            line-height: 30px;
+        }
+
+        .prestartedVmsEditorContent, .maxAssignedVmsPerUserEditorContent {
             width: 230px;
         }
 
-        .prestartedVmsEditor, .nameEditor, .maxAssignedVmsPerUserEditor {
+        .prestartedVmsEditor, .maxAssignedVmsPerUserEditor {
             float: right;
             width: 230px;
+        }
+
+        .nameEditorContent {
+            float: right !important;
+            width: 230px;
+            padding-left: 5px;
+            padding-right: 5px;
+        }
+
+        .nameEditor {
         }
 
         .editPrestartedVmsEditor, .editMaxAssignedVmsPerUserEditor {
@@ -403,7 +424,7 @@
                 <t:content>
                     <g:FlowPanel>
                         <g:FlowPanel addStyleNames="{style.sectionPanel}">
-                            <g:FlowPanel addStyleNames="{style.name} 
avmpw_name_pfly_fix">
+                            <g:FlowPanel addStyleNames="{style.name}">
                                 <g:FlowPanel 
addStyleNames="{style.prestartedLabelWithHelp}">
                                     <g:Label ui:field="nameLabel" 
addStyleNames="{style.nameLabel}" />
                                     <d:InfoIcon ui:field="poolNameIcon" 
addStyleNames="{style.poolNameIcon} avmpw_infoIcon_pfly_fix" />
diff --git a/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 
b/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
index 7f405ab..4e0ac35 100644
--- a/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
+++ b/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
@@ -113,7 +113,7 @@
 }
 #VmPopupWidget_name, #PoolNewPopupWidget_name, 
#PoolNewPopupWidget_prestartedVms, #PoolNewPopupWidget_maxAssignedVmsPerUser,
     #PoolEditPopupWidget_name, #PoolEditPopupWidget_editPrestartedVms, 
#PoolEditPopupWidget_incraseNumOfVms,
-    #PoolEditPopupWidget_editMaxAssignedVmsPerUser, 
#TemplateNewPopupWidget_name {
+    #PoolEditPopupWidget_editMaxAssignedVmsPerUser, 
#TemplateNewPopupWidget_name, #VmClonePopupWidget_name {
     line-height: 16px !important;
 }
 .cbe_checkbox_pfly_fix {
@@ -131,13 +131,6 @@
 .ape_expander_pfly_fix div span span:first-child {
     top: 4px;
     padding-right: 2px;
-}
-.avmpw_nameEditor_pfly_fix {
-    padding-left: 5px;
-}
-.avmpw_nameEditor_pfly_fix div:nth-child(2) {
-    padding-left: 5px;
-    padding-right: 5px;
 }
 #InstanceTypesPopupWidget .avmpw_nameEditor_pfly_fix input {
     line-height: 16px !important;
@@ -165,9 +158,6 @@
 div.avw_contentWidget_pfly_fix {
     position: relative;
     top: 6px;
-}
-.avmpw_name_pfly_fix {
-    padding-bottom: 30px !important;
 }
 .vmiw_networkAddButton_pfly_fix {
     width: 18px !important;


-- 
To view, visit http://gerrit.ovirt.org/31159
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f865deab00cab1e56fd39e6b2f9a00f507c4a26
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches