Lior Vernia has posted comments on this change. Change subject: webadmin: Allow selection of None for Cloud-Init network boot protocol ......................................................................
Patch Set 2: (1 comment) Well, I think the constant STATIC_IP would be rendered as "Static" (see Enums.properties). So I don't think roughness will be an issue. Localization is less of an issue when it comes to these, they're technical terms that I'd expect to be universal. They may be moved to the localized enum properties file if need be. http://gerrit.ovirt.org/#/c/31051/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java: Line 606: Line 607: model.getNetworkBootProtocolList().getSelectedItemChangedEvent().addListener(new IEventListener() { Line 608: @Override Line 609: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 610: setNetworkStaticDetailsStyle(model.getNetworkBootProtocolList().getSelectedItem() == null > Okay, interesting. I'll have to make sure that cloud-init accepts that, an Indeed. To the best of my knowledge, STATIC is being deprecated in favor of NONE. Line 611: || model.getNetworkBootProtocolList().getSelectedItem().getValue() == NetworkBootProtocol.STATIC_IP); Line 612: } Line 613: }); Line 614: -- To view, visit http://gerrit.ovirt.org/31051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51a76e968922fb62a07ccaced969c8b580de083 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
