Allon Mureinik has posted comments on this change.
Change subject: core: Add procedure to get active Hosts per Data Center
......................................................................
Patch Set 1: (5 inline comments)
I have a couple of design considerations about this DAO - see inline.
....................................................
File backend/manager/dbscripts/vds_sp.sql
Line 837: CREATE OR REPLACE FUNCTION GetActiveVdsByPoolId(v_storage_pool_id
UUID) RETURNS SETOF vds
Consider generalizing it - GetVdsInStatusByPoolId
Line 841: BEGIN
indent this to be parrallel to its END;
Line 844: WHERE status = 3 ;
Minor: Please document what enum constant "3" represents
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAO.java
Line 165: List<VDS> getActiveVdsByPoolId(Guid storagePoolId);
Don't we need a filtered version of this?
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java
Line 19: private final Guid STORAGE_POOL_ID = new
Guid("6d849ebf-755f-4552-ad09-9a090cda105d");
This should be moved to FixturesTool, IMHO.
--
To view, visit http://gerrit.ovirt.org/6144
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia88a820dc87e9b2178a4ef99a2e22762d1824bfb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
