Oved Ourfali has posted comments on this change. Change subject: core: Delay fencing until host storage lease renewal interval passed ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/31087/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java: Line 97: long interval = Config.<Integer>getValue(ConfigValues.HostStorageLeaseAliveCheckingInterval) * 1000; Line 98: long difference = System.currentTimeMillis() - getParameters().getLastUpdate(); Line 99: if (difference < interval) { Line 100: int sleepMs = (int)(interval - difference); Line 101: log.debug(String.format("Sleeping %s ms before proceeding with fence execution", sleepMs)); I'd use log.info here. In case of such an issue we might not have a debug log, and we will be interested in this information. Line 102: ThreadUtils.sleep(sleepMs); Line 103: } Line 104: } Line 105: http://gerrit.ovirt.org/#/c/31087/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 709: boolean executeSshSoftFencing = false; Line 710: if (!sshSoftFencingExecuted.getAndSet(true)) { Line 711: executeSshSoftFencing = true; Line 712: } Line 713: ResourceManager.getInstance().getEventListener().vdsNotResponding(vds, executeSshSoftFencing, lastUpdate); So what does lastUpdate reflect here? I mean, can we use that to know when and how long we should wait in order to check the lease? Line 714: } Line 715: return true; Line 716: } Line 717: -- To view, visit http://gerrit.ovirt.org/31087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45da28ae8a3007ed124d145a303f6201474a0f1c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
