Adam Litke has posted comments on this change. Change subject: Support socket name configuration in template form ......................................................................
Patch Set 5: Code-Review+2 (2 comments) http://gerrit.ovirt.org/#/c/28608/5/doc/mom-balloon%2Bksm.conf File doc/mom-balloon+ksm.conf: Line 97: # socketname will be instance-00000001.agent. Line 98: # The GuestQemuAgent Collector will try to open the socket: Line 99: # <socket_path>/<socket_name_template> Line 100: # after guest name substitution in the template. Line 101: socket_name_template: %(name)s.agent > Sure. I can change it to org.qemu.guest_agent.0.%(name)s.sock. Ahh, right. Keep it the way it is. If we decide to change the example default, then we can do that in a separate patch. Line 102: Line 103: [Collector: GuestNetworkDaemon] Line 104: # Helper program to convert guest names to IP addresses. This is only used by Line 105: # the GuestNetworkDaemon Collector. See doc/name-to-ip for an example. http://gerrit.ovirt.org/#/c/28608/5/mom/Collectors/Collector.py File mom/Collectors/Collector.py: Line 80 Line 81 Line 82 Line 83 Line 84 > Without this %(name)s configuration parameter throws this error: Ok. Consulted the documentation and raw=True merely disables string interpolation which is exactly what we want to do. -- To view, visit http://gerrit.ovirt.org/28608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf7d915f7bb3e5544625aa16205765e4099c6f57 Gerrit-PatchSet: 5 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Meghal .B. Gosalia <meghalgosa...@gmail.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Meghal .B. Gosalia <meghalgosa...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
