Ravi Nori has uploaded a new change for review.

Change subject: restapi : Create user API fails in SDK & CLI fails
......................................................................

restapi : Create user API fails in SDK & CLI fails

Create user fails with error HTTP 400
Request syntactically incorrect from
SDK and CLI

Change-Id: I308f5ebe3a7bcd4d980c7186fa995c704938ec93
Bug-Url: https://bugzilla.redhat.com/1122589
Signed-off-by: Ravi Nori <[email protected]>
---
M 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/JobMapper.java
2 files changed, 10 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/07/31107/1

diff --git 
a/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
 
b/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
index 9e0dfb6..2cf11e5 100644
--- 
a/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
+++ 
b/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
@@ -1977,6 +1977,13 @@
     </xs:complexContent>
   </xs:complexType>
 
+  <xs:complexType name="JobOwner">
+    <xs:complexContent>
+      <xs:extension base="User">
+      </xs:extension>
+    </xs:complexContent>
+  </xs:complexType>
+
   <xs:complexType name="Users">
     <xs:complexContent>
       <xs:extension base="BaseResources">
@@ -4515,7 +4522,7 @@
       <xs:extension base="BaseResource">
         <xs:sequence>
           <xs:element ref="status" minOccurs="0" maxOccurs="1"/>
-          <xs:element name="owner" type="User" minOccurs="0" maxOccurs="1"/>
+          <xs:element name="owner" type="JobOwner" minOccurs="0" 
maxOccurs="1"/>
           <xs:element name="start_time" type="xs:dateTime" minOccurs="0" 
maxOccurs="1"/>
           <xs:element name="end_time" type="xs:dateTime" minOccurs="0" 
maxOccurs="1"/>
           <xs:element name="last_updated" type="xs:dateTime" minOccurs="0" 
maxOccurs="1"/>
diff --git 
a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/JobMapper.java
 
b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/JobMapper.java
index e04cb32..8c2816f 100644
--- 
a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/JobMapper.java
+++ 
b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/JobMapper.java
@@ -4,8 +4,8 @@
 import java.util.Calendar;
 
 import org.ovirt.engine.api.model.Job;
+import org.ovirt.engine.api.model.JobOwner;
 import org.ovirt.engine.api.model.Status;
-import org.ovirt.engine.api.model.User;
 import org.ovirt.engine.api.restapi.utils.GuidUtils;
 import org.ovirt.engine.core.common.job.JobExecutionStatus;
 
@@ -19,7 +19,7 @@
         model.setDescription(entity.getDescription());
         model.setStatus(map(entity.getStatus(), null));
         if (entity.getOwnerId() != null) {
-            User user = new User();
+            JobOwner user = new JobOwner();
             user.setId(entity.getOwnerId().toString());
             model.setOwner(user);
         }


-- 
To view, visit http://gerrit.ovirt.org/31107
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I308f5ebe3a7bcd4d980c7186fa995c704938ec93
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to