Maor Lipchuk has posted comments on this change. Change subject: core [iSCSI multipath]: Add audit log when encounter connection issues ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/31092/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseIscsiBondCommand.java: Line 25: import org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil; Line 26: Line 27: public abstract class BaseIscsiBondCommand<T extends VdcActionParametersBase> extends CommandBase<T> { Line 28: Line 29: protected boolean encounterConnectionProblems = false; > consider removing intializiation done Line 30: Line 31: public BaseIscsiBondCommand(T parameters) { Line 32: super(parameters); Line 33: } Line 63: return !"0".equals(iscsiMap.get(a)); Line 64: } Line 65: }); Line 66: if (!failedConnectionsList.isEmpty()) { Line 67: log.errorFormat("Host {0} - {1} encounter problems to connect to the Iscsi Storage Server. The following connections were problematic (connectionid=vdsm result): {2}", > s/Iscsi/iSCSI done Line 68: host.getName(), Line 69: host.getId(), Line 70: iscsiMap.toString()); Line 71: encounterConnectionProblems = true; -- To view, visit http://gerrit.ovirt.org/31092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8951c9b6667abb33ee6dbd0d7d8c4c98d53a3227 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
