Oved Ourfali has submitted this change and it was merged. Change subject: core: Removing Memory Volumes Before VM and Disks ......................................................................
core: Removing Memory Volumes Before VM and Disks removeMemoryVolumes queries the VM and its disks and thus should come before we remove them. Note that removeMemoryVolumes can't be inside the transaction because it's not a pure DB operation, but also contains a VDSM (SPM) call. Change-Id: I24851385ab1c27a1da7fe8be04cfd9d8fb744b3f Signed-off-by: Idan Shaby <ish...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 2 files changed, 8 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit http://gerrit.ovirt.org/31080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24851385ab1c27a1da7fe8be04cfd9d8fb744b3f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches