Vojtech Szocs has posted comments on this change. Change subject: webadmin: LinuxMountPointValidationTest ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/30964/2/frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/LinuxMountPointValidationTest.java File frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/LinuxMountPointValidationTest.java: Line 12: Line 13: @Before Line 14: public void setUp() { Line 15: validation = new LinuxMountPointValidation() { Line 16: /** Stubbed away to avoid GWT dependencies */ > Please see changes in patch http://gerrit.ovirt.org/#/c/31021/ OK, on a second thought, UiCommon infra setup per test method might be an overkill in this case, maybe following is better: @ClassRule public static UiCommonSetup setup = new UiCommonSetup(); @Before public void setUp() { validation = new LinuxMountPointValidation(); } Line 17: @Override Line 18: protected String composeMessage() { Line 19: return null; Line 20: } -- To view, visit http://gerrit.ovirt.org/30964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6c159073b6e76097d769f02b05d8860196f83e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
