Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: JUnit rule for testing UiCommon models ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31021/2/frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java File frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java: Line 21: Line 22: @BeforeClass Line 23: public static void mockFrontend() { Line 24: Frontend frontend = setup.getMocks().frontend(); Line 25: when(frontend.getQueryCompleteEvent()).thenReturn(mock(Event.class)); > Well, I counted 7 models using getQueryCompleteEvent() method :-) I was worried about the case of re-mocking getQueryCompleteEvent() but I verified that re-mocking is still valid and working: @Test public void foo() { Event mock1 = mock(Event.class); when(mock1.getName()).thenReturn("one"); Event mock2 = mock(Event.class); when(mock2.getName()).thenReturn("two"); Frontend frontend = mock(Frontend.class); when(frontend.getQueryCompleteEvent()).thenReturn(mock1); when(frontend.getQueryCompleteEvent()).thenReturn(mock2); // re-mock Mockito.validateMockitoUsage(); // just in case assertThat(frontend.getQueryCompleteEvent().getName(), is("two")); } I'll update the patch to include getQueryCompleteEvent() convenience mock. Line 26: } Line 27: Line 28: protected void setUpVm(VmBase vm) { Line 29: vm.setName(VM_NAME); -- To view, visit http://gerrit.ovirt.org/31021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifca6bf6a6b77813fa90f419ccfe2ef9f2cd09561 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
