Omer Frenkel has posted comments on this change. Change subject: engine: search: vms.uptime is not working ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/30737/2/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java: Line 183: pair.setFirst("NOT " + BaseConditionFieldAutoCompleter.getLikeSyntax(caseSensitive)); Line 184: } Line 185: } Line 186: else if (UPTIME.equals(fieldName)) { Line 187: int milisecond = 1000; its better to declare this as class constant Line 188: pair.setSecond(StringHelper.trim(pair.getSecond(), '\'')); Line 189: TimeSpan ts = TimeSpan.parse(pair.getSecond()); Line 190: pair.setSecond(StringFormat.format("'%1$s'", ts.TotalMilliseconds < milisecond ? 0 : ts.TotalMilliseconds / milisecond)); Line 191: } -- To view, visit http://gerrit.ovirt.org/30737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I322a253557c71888307a60e7ae685dd38d637543 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
