Martin Peřina has posted comments on this change. Change subject: core: Introduce FencingPolicy ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/30194/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/FencingPolicyHelper.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/FencingPolicyHelper.java: > I think that since this piece of code will be duplicated in Eli, I don't understand here. What do you mean by code duplication? If we add new attribute to fencing policy, we just these methods (or create a new methods for different checks if needed). Line 1: package org.ovirt.engine.core.common.utils; Line 2: Line 3: import java.util.Set; Line 4: -- To view, visit http://gerrit.ovirt.org/30194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dfcd571b8329174f8d3acccf7136d0b5f83cacc Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
