Martin Peřina has posted comments on this change. Change subject: webadmin: Add FencingPolicy to cluster configuration ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/30195/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 1479: private void updateFencingPolicyContent(Version ver) { Line 1480: boolean supported = AsyncDataProvider.getInstance().isSkipFencingIfSDActiveSupported(ver.getValue()); Line 1481: getSkipFencingIfSDActiveEnabled().setIsChangable(supported); Line 1482: if (supported) { Line 1483: if (getEntity() == null) { > what is "getEntity"? isn't it supposed to be getEntity() returns VdsGroup instance. But in case you create new cluster, this instance is create after you click on save button. So if getEntity() returns null, it's a new cluster and I set skipFencingIfSDActive to true. If getEntity() is not null, I set skipFencingIfSDActive to existing fencing policy value. Line 1484: // this can happen when creating new cluster and cluster dialog is shown Line 1485: getSkipFencingIfSDActiveEnabled().setEntity(true); Line 1486: } else { Line 1487: getSkipFencingIfSDActiveEnabled().setEntity(getEntity().getFencingPolicy().isSkipFencingIfSDActive()); -- To view, visit http://gerrit.ovirt.org/30195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaecc1662324ce3d3072c9e850fcf8026ccfab0b2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
