Liron Aravot has posted comments on this change.

Change subject: core: Cleanup in RemoveImageCommand and anscentors
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File 
backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/NGuidTest.java
Line 10: /** A test for the {@link NGuid} class */
maybe it'll be good to include a little test to equalsGuid() as well in case 
someone changes anything in the future like removing it from the equals() 
method for some reason :) but some other code continues to use it.

--
To view, visit http://gerrit.ovirt.org/6024
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie66b450571d680e556dc812d9926161d9f190221
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to