Oved Ourfali has posted comments on this change. Change subject: core: Add fencing policy as parameter to fenceNode VDSM verb ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/30584/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java: Line 169: getTargetVds().getStoragePoolId(), Line 170: getTargetVds().getId() Line 171: ); Line 172: Line 173: // create a map SD_GUID -> SPM_HOST_ID s/SPM_HOST_ID/HOST_ID Line 174: for (StorageDomain sd : dbf.getStorageDomainDao().getAllForStoragePool( Line 175: getTargetVds().getStoragePoolId()) Line 176: ) { Line 177: if (sd.getStorageStaticData().getStorageDomainType() == StorageDomainType.Master || Line 175: getTargetVds().getStoragePoolId()) Line 176: ) { Line 177: if (sd.getStorageStaticData().getStorageDomainType() == StorageDomainType.Master || Line 178: sd.getStorageStaticData().getStorageDomainType() == StorageDomainType.Data) { Line 179: map.put(sd.getId(), hostIdRecord.getvds_spm_id()); write a comment saying that it is the host ID, not the SPM id. The DAO in this case is misleading. Line 180: } Line 181: } Line 182: } Line 183: return map; -- To view, visit http://gerrit.ovirt.org/30584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61ca142f0630ec2d8c1ec16e44c01af989c19079 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
