Tal Nisan has posted comments on this change. Change subject: core: Early return AddStorageDomainCommand's CDA ......................................................................
Patch Set 2: Code-Review+2 (1 comment) Minor comment http://gerrit.ovirt.org/#/c/30951/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java: Line 156: } Line 157: if (!isStorageFormatSupportedByStoragePool() || !isStorageFormatCompatibleWithDomain()) { Line 158: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST); Line 159: getReturnValue().getCanDoActionMessages().add( Line 160: String.format("$storageFormat %1$s", getStorageDomain().getStorageFormat().toString())); If you're at it, please change to addCanDoActionMessageVariable("storageFormat", etStorageDomain().getStorageFormat().toStr ing())) Line 161: return false; Line 162: } Line 163: return canAddDomain(); Line 164: } -- To view, visit http://gerrit.ovirt.org/30951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibed33518e5becb96b0de331376d158df29f06dca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
