Tal Nisan has posted comments on this change. Change subject: core: introduce AddNFSStorageDomainCommandTest ......................................................................
Patch Set 2: The tests seem ok but AddNFSStorageDomainCommand is basically just a wrapper to AddStorageDomainCommand with a bit of logic added around the way in AddStorageDomainCommon, why not change it to AddStorageDomainCommandTest? This command is not invokable via the API but you test it anyway by instantiating it directly and all the CDA logic resides within it -- To view, visit http://gerrit.ovirt.org/30950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e07f7fe5988dab9f37ecc040cdf3d839d776e23 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
