Shirly Radco has posted comments on this change. Change subject: reports: remove war file for new db ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/30967/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 141: if os.path.exists(entry['src']): Line 142: shutil.rmtree(entry['src']) Line 143: os.rename(entry['dst'], entry['src']) Line 144: else: Line 145: shutil.rmtree(entry['src']) > I think my suggestion above does this... Done Line 146: except Exception as e: Line 147: self._parent.logger.debug( Line 148: 'Exception during rename %s->%s', Line 149: entry['dst'], -- To view, visit http://gerrit.ovirt.org/30967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dc78b70df372d83c04d9eb4a47989925f9705d7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
