Allon Mureinik has uploaded a new change for review.
Change subject: core: AddStorageDomainCommand.getTargetStoragePool
......................................................................
core: AddStorageDomainCommand.getTargetStoragePool
Extracted AddStorageDomainCommand.getTargetStoragePool for later use
(not to mention the increased readability).
Change-Id: I3776beb5a7426e010f05ca0b4f3dffb128346ed7
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
1 file changed, 11 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/30959/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
index 9c31d14..d7f0b2c 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
@@ -161,13 +161,10 @@
private boolean isStorageFormatSupportedByStoragePool() {
StorageFormatType storageFormat =
getStorageDomain().getStorageFormat();
- StoragePool targetStoragePool = getStoragePool();
+ StoragePool targetStoragePool = getTargetStoragePool();
if (targetStoragePool == null) {
- targetStoragePool =
getStoragePoolDAO().get(getVds().getStoragePoolId());
- if (targetStoragePool == null) {
- return false;
- }
+ return false;
}
Set<StorageFormatType> supportedStorageFormats =
@@ -176,6 +173,15 @@
}
+ private StoragePool getTargetStoragePool() {
+ StoragePool targetStoragePool = getStoragePool();
+
+ if (targetStoragePool == null) {
+ targetStoragePool =
getStoragePoolDAO().get(getVds().getStoragePoolId());
+ }
+ return targetStoragePool;
+ }
+
private boolean isStorageFormatCompatibleWithDomain() {
StorageFormatType storageFormat =
getStorageDomain().getStorageFormat();
StorageType storageType = getStorageDomain().getStorageType();
--
To view, visit http://gerrit.ovirt.org/30959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3776beb5a7426e010f05ca0b4f3dffb128346ed7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
