Allon Mureinik has uploaded a new change for review.
Change subject: core: AddStorageDomainCommand singleton list
......................................................................
core: AddStorageDomainCommand singleton list
Use Collections.singletonList instead of Arrays.asList wherever possible
to improve readability and increase performance.
Change-Id: Ic973514f0545256238725f7aba17ad9cc850318e
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/54/30954/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
index fc4c3cb..f10ee7b 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
@@ -3,7 +3,6 @@
import static
org.ovirt.engine.core.bll.MultiLevelAdministrationHandler.SYSTEM_OBJECT_ID;
import java.util.ArrayList;
-import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
@@ -121,11 +120,11 @@
VDSCommandType.ConnectStorageServer,
new
StorageServerConnectionManagementVDSParameters(getParameters().getVdsId(),
Guid.Empty,
connection.getstorage_type(),
- new ArrayList<>(Arrays.asList(new
StorageServerConnections[]{connection}))))
+ new
ArrayList<>(Collections.singletonList(connection))))
.getReturnValue();
return new Pair<Boolean, Integer>(StorageHelperDirector.getInstance()
.getItem(connection.getstorage_type())
- .isConnectSucceeded(result, Arrays.asList(connection)),
+ .isConnectSucceeded(result,
Collections.singletonList(connection)),
Integer.parseInt(result.values().iterator().next()));
}
--
To view, visit http://gerrit.ovirt.org/30954
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic973514f0545256238725f7aba17ad9cc850318e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
