Adam Litke has posted comments on this change. Change subject: Add HostTime Collector for writing time based mom policies. ......................................................................
Patch Set 1: Code-Review-1 (1 comment) Great patch! Just a minor suggested change please. http://gerrit.ovirt.org/#/c/28613/1/mom/Collectors/HostTime.py File mom/Collectors/HostTime.py: Line 18: This Collector returns host time statistics using python datetime module. Line 19: These stats would be useful for creating a time based policy. Line 20: Time interval at which this collector is run is controlled in config file. Line 21: It provides the following stats - Line 22: year, month, day, hour, minute, second, microsecond It's helpful if the collector uses a prefix for all fields returned. It makes the policy, plotfiles, and logs all easier to read. For this collector, I'd suggest the prefix 'time_'. Line 23: """ Line 24: def __init__(self, properties): Line 25: pass Line 26: -- To view, visit http://gerrit.ovirt.org/28613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88a9d87d5f7e5a5c5baae2c20518a26a513dcda4 Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Meghal .B. Gosalia <meghalgosa...@gmail.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
