Vojtech Szocs has posted comments on this change.

Change subject: userportal,webadmin: Reload on logout
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/30914/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java:

Line 31:                 MainModelSelectionChangeEvent.fire(eventBus, 
commonModel.getSelectedItem());
Line 32:             }
Line 33:         });
Line 34: 
Line 35:         commonModel.getSignedOutEvent().addListener(new 
IEventListener() {
IIRC, since CommonModel#signOut was removed, this listener will never be 
called, so we can remove it.
Line 36:             @Override
Line 37:             public void eventRaised(Event ev, Object sender, EventArgs 
args) {
Line 38: 
Line 39:                 // Clear CommonModel reference after the user signs 
out,


-- 
To view, visit http://gerrit.ovirt.org/30914
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5c665ed85495b7c4baf4f0984b006ee2a7730f9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to