Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: Making separate WSP CSR available also in temp file ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/30910/2/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py File packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py: Line 137: mode='w', Line 138: delete=False, Line 139: ) Line 140: self._csr_file.write(req) Line 141: self._csr_file.close() Looking at the documentation, the temporary file will be deleted right after the close() call. I think you should use tempfile.mkstemp. Line 142: self.dialog.note( Line 143: text=_( Line 144: "\nThe certificate request is also available at:\n" Line 145: "{fname}\n\n" -- To view, visit http://gerrit.ovirt.org/30910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If517c577ead43e604442c7d468f034c2c8eaf276 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
