Daniel Erez has posted comments on this change. Change subject: webadmin: Added tooltip for mount options in new storage dialog ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/30860/1/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 1967: Line 1968: @DefaultStringValue("Enter a valid FS type (e.g. nfs/glusterfs/cifs/smbfs etc.") Line 1969: String posixVfsTypeHint(); Line 1970: Line 1971: @DefaultStringValue("Enter additional Mount Options, as you would normally provide them to the mount command using the -o argument.\nThe mount options should be provided in a comma-separated list. See man mount for a list of valid mount options.") suggestion - for readability, wrap 'man mount' with quotes. Line 1972: String mountOptionsHint(); Line 1973: Line 1974: @DefaultStringValue("Event Details") Line 1975: String eventDetailsTitle(); -- To view, visit http://gerrit.ovirt.org/30860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieded652097ecd17f17ee27678b57818f4ca88be2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
