Alona Kaplan has uploaded a new change for review.

Change subject: webadmin:  Unneeded scroll bar on KeyValueWidget
......................................................................

webadmin:  Unneeded scroll bar on KeyValueWidget

Change-Id: Ic7f26ace9c783467d8f02d4c9df511b30032bd7e
Bug-Url: https://bugzilla.redhat.com/1116737
Bug-Url: https://bugzilla.redhat.com/1116580
Signed-off-by: Alona Kaplan <alkap...@redhat.com>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.ui.xml
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/VnicProfilePopupView.java
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/30824/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.ui.xml
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.ui.xml
index b0bf218..72e97fa 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.ui.xml
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.ui.xml
@@ -10,7 +10,7 @@
                margin-top: 10px;
        }
         .buttonStyle {
-               margin-top: 7px;
+               margin-top: 6px;
                margin-right: 7px;
                width: 9px;
                height: 10px;
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/VnicProfilePopupView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/VnicProfilePopupView.java
index 640a925..8a14d5f 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/VnicProfilePopupView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/VnicProfilePopupView.java
@@ -74,7 +74,7 @@
     @WithElementId("portMirroring")
     protected EntityModelCheckBoxEditor portMirroringEditor;
 
-    @UiField
+    @UiField(provided = true)
     @Ignore
     public KeyValueWidget<KeyValueModel> customPropertiesSheetEditor;
 
@@ -92,6 +92,7 @@
     public VnicProfilePopupView(EventBus eventBus, ApplicationResources 
resources, ApplicationConstants constants) {
         super(eventBus, resources);
         publicUseEditor = new EntityModelCheckBoxEditor(Align.RIGHT);
+        customPropertiesSheetEditor = new 
KeyValueWidget<KeyValueModel>("380px"); //$NON-NLS-1$
         networkEditor = new ListModelListBoxEditor<Network>(new 
NullSafeRenderer<Network>() {
             @Override
             public String renderNullSafe(Network network) {


-- 
To view, visit http://gerrit.ovirt.org/30824
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7f26ace9c783467d8f02d4c9df511b30032bd7e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to