Vered Volansky has posted comments on this change. Change subject: core: Storage validation when running stateless VM ......................................................................
Patch Set 3: (1 comment) Allon, already stated in my TBD comment that I'm going to add tests for new functionality. http://gerrit.ovirt.org/#/c/30776/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java: Line 884: protected boolean validateSpaceRequirements() { Line 885: fetchVmDisksFromDb(); Line 886: List<DiskImage> disksList = getVm().getDiskList(); Line 887: MultipleStorageDomainsValidator msdValidator = createMultipleStorageDomainsValidator(disksList); Line 888: return validate(msdValidator.allDomainsHaveSpaceForNewDisks(disksList)); > do we want to check space for new disks? no need to check only for snapshot It's the same test for both snapshots and new disks, since when creating a snapshot we want to check there's enough space for the new AI. Line 889: } Line 890: Line 891: @Override Line 892: protected List<Class<?>> getValidationGroups() { -- To view, visit http://gerrit.ovirt.org/30776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id04203119cce475afeef7658db50e132b0c7036a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
