Daniel Erez has posted comments on this change. Change subject: core: Add test for import unregistered VM ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/29795/3/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java: Line 71: displayTypeMap.get(osId).put(null, Arrays.asList(DisplayType.qxl)); Line 72: when(osRepository.getDisplayTypes()).thenReturn(displayTypeMap); Line 73: mockVdsGroup(); Line 74: try { Line 75: xmlOvfData = new String(Files.readAllBytes(Paths.get(VM_OVF_XML_DATA))); could be simplified a bit by using apache commons readFileToString. Line 76: } catch (IOException e) { Line 77: e.printStackTrace(); Line 78: } Line 79: } Line 73: mockVdsGroup(); Line 74: try { Line 75: xmlOvfData = new String(Files.readAllBytes(Paths.get(VM_OVF_XML_DATA))); Line 76: } catch (IOException e) { Line 77: e.printStackTrace(); consider extracting the try/catch block to a method.. Line 78: } Line 79: } Line 80: Line 81: @Test -- To view, visit http://gerrit.ovirt.org/29795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6f68a66da4de6b9dbfb664d3678b25582a82496 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
