Michael Kublin has posted comments on this change. Change subject: core: Making code readable ......................................................................
Patch Set 1: Looks good to me, approved I suppose in order to get +2, I need to perform a some lecture where I will explain that for each pattern was introduced from java 1.5, remove of unneeded code is good, and now a code looks clearly, so guys +1 if these ok from java point of view but u not sure about flow, here the flow left the same, so why I did not get +2. I start worried about your guys, really -- To view, visit http://gerrit.ovirt.org/5924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb974c97a6f6f4ccf9841ec4d14cb3e216836bb1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
