Eli Mesika has posted comments on this change. Change subject: core: Introduce FencingPolicy ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/30194/3/packaging/dbscripts/upgrade/03_06_0040_skip_fencing_when_sd_is_alive.sql File packaging/dbscripts/upgrade/03_06_0040_skip_fencing_when_sd_is_alive.sql: Line 1: -- By default set to false not to break upgrade Line 2: SELECT fn_db_add_column('vds_groups', 'skip_fencing_if_sd_active', 'boolean DEFAULT false'); Line 3: Line 4: -- Set to true for all 3.5 clusters Line 5: UPDATE vds_groups SET skip_fencing_if_sd_active = true WHERE compatibility_version = '3.5'; > I wouldn't do that. don't we want to have this functioning in default for all 3.5 clusters. As far as I understand, it is not matter if the cluster exists or is new , we want to prevent needless host fencing and therefor IMO we should enforce that on existing clusters as well -- To view, visit http://gerrit.ovirt.org/30194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dfcd571b8329174f8d3acccf7136d0b5f83cacc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
