Ayal Baron has posted comments on this change. Change subject: core: When adding floating disk, an incorrect event is logged ......................................................................
Patch Set 1: I would prefer that you didn't submit this (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java Line 73: isAddToVm = !Guid.Empty.equals(parameters.getVmId()); this should not be a member. A function at most (as it is computed from the value of another member) or just inline it Line 402: return getSucceeded() ? (isAddToVm ? AuditLogType.USER_ADD_DISK_TO_VM_FINISHED_SUCCESS if we're in END_SUCCESS why the hell do we need to check getSucceeded? Also, you added 4 nested 'if' statements here which do not make the code very readable. Line 408: return AuditLogType.USER_ADD_DISK_TO_VM_FINISHED_FAILURE; so here you don't care if we're adding to VM or not? -- To view, visit http://gerrit.ovirt.org/6048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I068b7ebb2a0c12adf7ca612c7473f2e55331a9fd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
