Yair Zaslavsky has posted comments on this change. Change subject: aaa: present authz and namespace information ......................................................................
Patch Set 3: (5 comments) http://gerrit.ovirt.org/#/c/30645/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java: Line 40: @Override Line 41: public String getValue(Permissions object) { Line 42: return object.getNamespace(); Line 43: } Line 44: }; > Please add- namespaceColumn.makeSortable(); Done Line 45: getTable().addColumn(namespaceColumn, constants.namespace(), "300px"); //$NON-NLS-1$ Line 46: Line 47: TextColumnWithTooltip<Permissions> authzColumn = new TextColumnWithTooltip<Permissions>() { Line 48: @Override http://gerrit.ovirt.org/#/c/30645/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 3743: Line 3744: @DefaultStringValue("Save As Pdf") Line 3745: String exportToPdf(); Line 3746: Line 3747: @DefaultStringValue("Authorization provider") > ApplicationConstants extends CommonApplicationConstants. Done Line 3748: String authzProvider(); Line 3749: Line 3750: @DefaultStringValue("Namespace") Line 3751: String namespace(); http://gerrit.ovirt.org/#/c/30645/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/SystemPermissionView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/SystemPermissionView.java: Line 93: public String getValue(Permissions object) { Line 94: return object.getAuthz(); Line 95: } Line 96: }; Line 97: authzColumn.makeSortable(); > The other columns in this class are not sortable yet. Done Line 98: table.addColumn(authzColumn, constants.authz(), "200px"); //$NON-NLS-1$ Line 99: Line 100: TextColumnWithTooltip<Permissions> roleColumn = new TextColumnWithTooltip<Permissions>() { Line 101: @Override http://gerrit.ovirt.org/#/c/30645/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java: Line 62: }; Line 63: userNameColumn.makeSortable(VdcUserConditionFieldAutoCompleter.USER_NAME); Line 64: getTable().addColumn(userNameColumn, constants.userNameUser(), "150px"); //$NON-NLS-1$ Line 65: Line 66: getTable().addColumn(new TextColumnWithTooltip<DbUser>() { > makeSortable? Done Line 67: @Override Line 68: public String getValue(DbUser object) { Line 69: return object.getNamespace(); Line 70: } Line 69: return object.getNamespace(); Line 70: } Line 71: }, constants.namespace(), "150px"); //$NON-NLS-1$ Line 72: Line 73: getTable().addColumn(new TextColumnWithTooltip<DbUser>() { > makeSortable? Done Line 74: @Override Line 75: public String getValue(DbUser object) { Line 76: return object.getDomain(); Line 77: } -- To view, visit http://gerrit.ovirt.org/30645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b2bc84364b8ac7ee180848a66bd03489b03e4d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
