Lior Vernia has posted comments on this change. Change subject: webadmin: Wrong vnics when creating vm from blank template ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/30637/1//COMMIT_MSG Commit Message: Line 13: Line 14: This override happens in EditProfileBehavior->initSelectedProfile, but Line 15: since it is called before the registration of ProfileInstanceTypeEditor Line 16: to SelectedItemChangedEvent of VnicInstanceType the new selection of Line 17: 'Empty' profile isn't reflected on VnicInstanceType.NetworkInterface. > I disagree with this analysis. When talking about the new VM dialog, to my Disregard the first paragraph, it's irrelevant because that's not what you meant. The second one is the important one. Line 18: Line 19: This patch fixes it by calling syncSelectedItemWithNetworkInterface(..) Line 20: also before the registration and not just from the eventRaised(..). Line 21: -- To view, visit http://gerrit.ovirt.org/30637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60be6b21050c43bb004e56688f8e306b5b943d24 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
