Allon Mureinik has posted comments on this change. Change subject: core: allow read-only for VirtIO-SCSI DirectLUN disks ......................................................................
Patch Set 5: Code-Review+1 (1 comment) +1 on the backend side. To minor nits: 1. style issue, see inline. 2. please renumber the upgrade script to packaging/dbscripts/upgrade/03_06_0050_update_sgio_for_readonly_disks.sql http://gerrit.ovirt.org/#/c/30123/5/packaging/dbscripts/upgrade/03_06_0030_update_sgio_for_readonly_disks.sql File packaging/dbscripts/upgrade/03_06_0030_update_sgio_for_readonly_disks.sql: Line 4: -- should use SCSI device emulation instead. Line 5: Line 6: UPDATE base_disks Line 7: SET sgio = NULL Line 8: WHERE base_disks.disk_id in (SELECT device_id FROM vm_device WHERE is_readonly = TRUE); style: s/in/IN/ -- To view, visit http://gerrit.ovirt.org/30123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic317722be9ef8978b50352c12bc06ea8c906dcd0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Paolo Bonzini <pbonz...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
