Yair Zaslavsky has posted comments on this change. Change subject: engine : CommandExecutor should handle exception in CallBackMethods ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/30463/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 76: callBack.onSucceeded(cmdId, coco.getChildCommandIds(cmdId)); Line 77: coco.updateCallBackNotified(cmdId); Line 78: iterator.remove(); Line 79: } catch (Exception ex) { Line 80: log.errorFormat("Error invoking onSucceeded for SUCCEEDED command {0}", cmdId.toString()); i still think that it is possible to refactor the error handling, even if to an external method. but it's up to you. Line 81: coco.updateCommandStatus(cmdId, CommandStatus.FAILED); Line 82: } Line 83: break; Line 84: case ACTIVE: -- To view, visit http://gerrit.ovirt.org/30463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06b82f29ac31fd09903d76f87e839d8ac32ef1e1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
