Juan Hernandez has posted comments on this change. Change subject: aaa: NPE when adding permission to datacenter ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/30519/5/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResourceTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResourceTest.java: Line 83: verifyTestAllocateVmActionResponse(resource.allocatevm(new Action())); Line 84: } Line 85: Line 86: private void setUpGetUserExpectations() { Line 87: currentUser.setId(GUIDS[0]); Any reason to not assign GUIDS[0] to the mock of the user when it is created? Line 88: } Line 89: Line 90: private void setUpGetVmExpectations(int times) throws Exception { Line 91: while (times-- > 0) { -- To view, visit http://gerrit.ovirt.org/30519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I379ffbac3e8323cf575d9d14c860dd03a6b6e686 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
