Omer Frenkel has posted comments on this change. Change subject: core: not migrate if dst host resolved to src host ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/30239/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java: Line 379: Line 380: private boolean validateDestinationVdsAddress() { Line 381: VDS dstVds = getDestinationVds(); Line 382: Line 383: if (dstVds == null) { this will be null for normal migrate (when user doesnt specify destination) so in this case i guess you should return true. did you check if the canSchedule method select the dest host? Line 384: log.warnFormat("cannot migrate to VDS: null reference"); Line 385: return false; Line 386: } Line 387: -- To view, visit http://gerrit.ovirt.org/30239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d05fb0c1f8108580edc391f87b9e95ffc2ae434 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
