Alon Bar-Lev has posted comments on this change. Change subject: engine : [AAA] Get users by domain returns partial list of users ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/30544/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 25 Line 26 Line 27 Line 28 Line 29 > Alon, can you remind me if we have considered to provide this value the con the limit is a limit to avoid infinite memory consumption as we do not support paging to this class. there is no sense in return large ldap array in one chunk... or better to change the interface to use paging, for these who use the AuthzUtils so currently we do not return more than this limit for both api and ui. for ui there is no sense in changing behavior. for api, if the api does not accumulate all in memory before sending to remote, we can move paging handling to there and remove restriction. however, I am almost sure that the api does accumulate all in memory. -- To view, visit http://gerrit.ovirt.org/30544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4c121b0edd6966c518b46aa8e98c24be6cb74c8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
